Skip to content

feat: Migrate from FreshCryptoLib to SmoothCryptoLib #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
itasli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Migrate from FreshCryptoLib to SmoothCryptoLib #76

itasli wants to merge 2 commits into from

Conversation

@itasli
Copy link

@itasli itasli commented Dec 29, 2025

Replace deprecated and unaudited FreshCryptoLib dependency with SmoothCryptoLib from same developpers, improves blockchain compatibility as well.

Changes

  • Remove: FreshCryptoLib submodule and imports
  • Add: SmoothCryptoLib submodule
  • Update: Base64Url → OpenZeppelin Base64.encodeURL()
  • Maintain: Identical API compatibility (no breaking changes)

Benefits

  • Compatibility: Works on Polygon zkEVM and other chains without ModExp precompile
  • Audits: Multiple security audits + partial formal verification

Compatibility

  • API: Identical function signatures
  • Tests: All existing tests pass
  • Fallback: Maintains RIP-7212 precompile + library pattern

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 29, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itasli @cb-heimdall